tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: ncr53c9x fallout from asserting kernel lock in scsipi_base



> After the change in revision 1.156 of src/sys/dev/scsipi/scsipi_base.c to
> assert that the kernel lock is held in scsipi_lookup_periph(), my SBus-based
> sparc64 crashed with:
> 
>   panic: kernel diagnostic assertion "KERNEL_LOCKED_P()" failed: file 
> "/usr/src/sys/dev/scsipi/scsipi_base.c", line 221
> 
> The backtrace is:
> 
>   kern_assert
>   scsipi_lookup_periph
>   scsipi_async_event
>   ncr53c9x_update_xfer_mode
>   ncr53c9x_init
>   ncr53c9x_attach
> 
> The attached allows it to boot and run, but is it correct?

i had a look at all of the scsi drivers, and this and ninjascsi are
the only broken ones.  i have a change identical to this in my tree.

it seems the best solution for now, but please add /* XXXSMP scsipi */
comments.


.mrg.


Home | Main Index | Thread Index | Old Index