tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Solved! (was: why is this needed?)




Am 17.08.2009 um 21:46 schrieb David Young:

On Mon, Aug 17, 2009 at 09:33:48PM +0200, Marc Balmer wrote:

Am 17.08.2009 um 21:30 schrieb David Young:

On Mon, Aug 17, 2009 at 09:25:33PM +0200, Marc Balmer wrote:

Am 17.08.2009 um 20:57 schrieb David Young:

On Mon, Aug 17, 2009 at 04:04:08PM +0200, Marc Balmer wrote:
While here, I removed the unneeded and empty gscpcib_childdetach
function.

The gscpcib_childdetach function, empty though it is, is needed so
that
children can be detached.  Please put that back. :-)

hmm.  Other gpio drivers seem not to have it, and work nonetheless
(eg.
gpiosim(4)).  why is it needed in this particular case?

It is needed so that we can detach the children of gscpcib(4).
According to the manual page, those children are an ISA bus and a GPIO
bus.

GPIO did not even work until I fixed it.

Right, and ISA only has a detachment routine in my working copy.  So
it's not a functional regression that any user will see.  Don't worry,
I'll take care of all of it in a commit later today.

And what will that change?  Why is childdetach needed?



Home | Main Index | Thread Index | Old Index