tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kernel_lock, splbio() and SMP_SAFE



Manuel Bouyer <bouyer%antioche.eu.org@localhost> wrote:
> This seems to happen only before starting init, so it doesn't cause big
> harms. remplacing the KASSERT with a call to debugger() shows that in
> multiuser, wdstart and sdstart are called with kernel_lock held. 
> 

From i386 cpu_dumpconf:

        ...
        if (bdev->d_psize == NULL)
                goto bad;
        nblks = (*bdev->d_psize)(dumpdev);
        ...

I think this call needs KERNEL_LOCK()/KERNEL_UNLOCK_ONE() wrap. It seems OK
just to wrap the call in init_main.c, instead of changing MD routines.

-- 
Mindaugas


Home | Main Index | Thread Index | Old Index