Re: Removal of some KAUTH_GENERIC_ISSUSER (pass 1)

[Andrew Doran <ad%netbsd.org@localhost>]

On Sun, Apr 12, 2009 at 12:52:16PM +0000, Andrew Doran wrote:

> On Sun, Apr 12, 2009 at 02:10:31AM +0300, Elad Efrat wrote:
> 
> > On Sun, Apr 12, 2009 at 12:40 AM, Andrew Doran <ad%netbsd.org@localhost> 
> > wrote:
> > > On Sat, Apr 11, 2009 at 04:46:34AM +0300, Elad Efrat wrote:
> > >
> > >> ? - KAUTH_MACHDEP_CACHEFLUSH_ALL, for checking if the whole CPU cache
> > >> ? ? can be flushed (used in compat code only).
> > >
> > > Is there a reason for _ALL (so specific)?
> > 
> > Sure: the code where I use this allows flushing the "data" and
> > "instruction" caches as well, and makes a distinction about "all".
> 
> Ok. The existing intent check is likely there for performance reasons. In
> this case I don't see the utility of being so granular when it comes to the
> access check.

To expand on the above, I don't have a strong opinion on this. I am just
pointing out what I see.