Re: Removal of some KAUTH_GENERIC_ISSUSER (pass 1)

[Andrew Doran <ad%netbsd.org@localhost>]

On Sat, Apr 11, 2009 at 04:46:34AM +0300, Elad Efrat wrote:

>   - KAUTH_MACHDEP_CACHEFLUSH_ALL, for checking if the whole CPU cache
>     can be flushed (used in compat code only).

Is there a reason for _ALL (so specific)?

+               /*                                                              
+                * According to SCO documentation, this is the startup process  
+                * trying to remount the root file-system.                      
+                */                                                             
+               struct mount *rootfs = CIRCLEQ_FIRST(&mountlist);               
+                                                                               
+               /* Make sure this is the root file-system. */                   
+               if (!(rootfs->mnt_flag & MNT_ROOTFS)) {                         
+                       return (EINVAL);                                        
+               }              

Why check this? In any case, SCO_A_REMOUNT is ignored.

+               if (!(rootfs->mnt_flag & MNT_ROOTFS)) {

KNF: ((value & FLAG) == 0)

+               if (error)                                                      
+                       return (error);                                         
+               return (0);                                                     

This is equivalent to:

                return error;

+               /* NOTREACHED */  

NOTREACHED is implicit and so not required.