Re: CVS commit: src/sys/arch/macppc/dev

["Marco Trillo" <marcotrillo%gmail.com@localhost>]

Hi,

On Wed, Sep 10, 2008 at 2:57 PM, Michael Lorenz <macallan%netbsd.org@localhost> 
wrote:
> Gah, I'm blind - didn't look deep enough. I'll fix that.
> ( Doesn't really matter since we don't really map anything but for
> correctness' sake I'll change it back. Tim's new bus_space code which
> actually keeps track of bus_space_map()s exposed a whole bunch of cases
> where drivers mapped way too much address space, overlapped with other
> drivers' mappings and subsequently got rejected and stopped working. This
> looked like another case like that. )

In fact obio.c already maps its own space for FCRs and GPIOs:

171:        error = bus_space_map (pa->pa_memt, ca.ca_baseaddr, 0x80, 0, &bsh);

So it looks like the mapping done in if_wi_obio.c overlaps with the
mapping done in obio.c; don't known if this causes problems.

Maybe if_wi_obio should be mapping only its own baseaddr + 0x1a000,
length 0x100 space and using the common obio map for FCRs and GPIOs.

Regards,
Marco.