Re: CVS commit: src/sys/arch/macppc/dev

["Marco Trillo" <marcotrillo%gmail.com@localhost>]

Hi,

>Modified Files:
>        src/sys/arch/macppc/dev: if_wi_obio.c
>
>Log Message:
>get rid if some mistyped magic number, spotted by Marco Trillo
>While there map only the space we actually need.
>Needs to be tested on actual hardware.

I think there is a problem with the new mapping: it maps "0x70", so
only one page:

     98:        bus_space_map(sc->sc_tag, ca->ca_baseaddr, 0x70, 0,
&sc->sc_bsh);

but then accesses offsets "0x1c000" and "0x1a3e0" which are not
covered by the new mapping:

                    154:        bus_space_write_4(sc->sc_tag,
sc->sc_bsh, 0x1c000, 0);
    155:
                    156:        /* Initialize the card. */
    157:        bus_space_write_4(sc->sc_tag, sc->sc_bsh, 0x1a3e0, 0x41);


Regards,
Marco.