Re: CVS commit: src

[Thor Lancelot Simon <tls%rek.tjls.com@localhost>]

On Sat, Apr 12, 2008 at 02:14:27PM +0100, Mindaugas Rasiukevicius wrote:
> Thor Lancelot Simon <tls%rek.tjls.com@localhost> wrote:
> > > - Why crypto_mtx is not set to IPL_SOFTNET, but IPL_NET?
> > 
> > It replaced calls to "splcrypto()", which was splnet().  The actual
> > hardware drivers currently in the tree all use splnet() for mutual
> > exclusion and there are a couple of cases where driver done routines
> > can need the crypto_mtx -- so I think it probably has to be at IPL_NET,
> > no?
> 
> The current code uses software interrupt, and IPL_SOFT* levels are used to
> block them. Why blocking of hard interrupts (at IPL_NET) is needed?

But the hardware drivers take the mutex before calling the done function,
when requests finish at the hardware.  Most of the existing drivers run
at splnet() -- if they might be running at IPL_NET when they take the mutex,
doesn't the mutex have to be initialized with IPL_NET?

Thor