Re: CVS commit: src

[Mindaugas Rasiukevicius <rmind%NetBSD.org@localhost>]

> Module Name:    src
> Committed By:   tls
> Date:           Thu Apr 10 22:48:42 UTC 2008
> 
> Modified Files:
>         src/doc: CHANGES
>         src/share/man/man4: crypto.4
>         src/sys/opencrypto: crypto.c cryptodev.c cryptodev.h
> 
> Log Message:
> Extend crypto.4 interface:
> 
>         * Asynchronous operation with result retrieval via select/poll
>         * Mutliple-request submit/retrieve ioctls
>         * Mutliple-session create-destroy ioctls

> cvs rdiff -r1.26 -r1.27 src/sys/opencrypto/crypto.c
> cvs rdiff -r1.35 -r1.36 src/sys/opencrypto/cryptodev.c

- Why crypto_mtx is not set to IPL_SOFTNET, but IPL_NET?

- It is not good to allocate the memory, while lock (especially spin-lock)
  is held (eg. in csecreate).

- There is no need to check for NULL value in case of PR_WAITOK/KM_SLEEP.
  At least in this case, especially when it improves readability.

-- 
Best regards,
Mindaugas
www.NetBSD.org