Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/fs/puffs Backout previous bugfix attempt for unmounts. T...



details:   https://anonhg.NetBSD.org/src/rev/e84f29430a56
branches:  trunk
changeset: 780844:e84f29430a56
user:      manu <manu%NetBSD.org@localhost>
date:      Thu Aug 09 07:46:18 2012 +0000

description:
Backout previous bugfix attempt for unmounts. That changes did not
address the real problem.

diffstat:

 sys/fs/puffs/puffs_vfsops.c |  18 ++----------------
 1 files changed, 2 insertions(+), 16 deletions(-)

diffs (53 lines):

diff -r 09037630db57 -r e84f29430a56 sys/fs/puffs/puffs_vfsops.c
--- a/sys/fs/puffs/puffs_vfsops.c       Thu Aug 09 07:26:28 2012 +0000
+++ b/sys/fs/puffs/puffs_vfsops.c       Thu Aug 09 07:46:18 2012 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: puffs_vfsops.c,v 1.105 2012/07/27 07:38:44 manu Exp $  */
+/*     $NetBSD: puffs_vfsops.c,v 1.106 2012/08/09 07:46:18 manu Exp $  */
 
 /*
  * Copyright (c) 2005, 2006  Antti Kantee.  All Rights Reserved.
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: puffs_vfsops.c,v 1.105 2012/07/27 07:38:44 manu Exp $");
+__KERNEL_RCSID(0, "$NetBSD: puffs_vfsops.c,v 1.106 2012/08/09 07:46:18 manu Exp $");
 
 #include <sys/param.h>
 #include <sys/kernel.h>
@@ -61,7 +61,6 @@
 MODULE(MODULE_CLASS_VFS, puffs, "putter");
 
 VFS_PROTOS(puffs_vfsop);
-extern struct vfsops puffs_vfsops;
 
 #ifndef PUFFS_PNODEBUCKETS
 #define PUFFS_PNODEBUCKETS 256
@@ -321,14 +320,6 @@
 
        vfs_getnewfsid(mp);
 
-       /*
-        * Hold a reference on vfs so that the puffs module cannot be 
-        * unloaded while the pools items have not been freed by unmount.
-        */
-       mutex_enter(&vfs_list_lock);
-       puffs_vfsops.vfs_refcount++;
-       mutex_exit(&vfs_list_lock);
-
  out:
        if (error && pmp && pmp->pmp_pi)
                putter_detach(pmp->pmp_pi);
@@ -457,11 +448,6 @@
                kmem_free(pmp->pmp_pnodehash, BUCKETALLOC(pmp->pmp_npnodehash));
                kmem_free(pmp, sizeof(struct puffs_mount));
                error = 0;
-
-               /*
-                * One less user for puffs pools
-                */
-               vfs_delref(&puffs_vfsops);
        } else {
                mutex_exit(&pmp->pmp_lock);
        }



Home | Main Index | Thread Index | Old Index