Source-Changes-D archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys/net/npf
> Date: Tue, 15 Sep 2026 17:13:27 +0000
> From: Taylor R Campbell <riastradh%NetBSD.org@localhost>
>
> > Module Name: src
> > Committed By: christos
> > Date: Sun Sep 13 23:26:26 UTC 2026
> >
> > Modified Files:
> > src/sys/net/npf: npf_ext_route.c
> >
> > Log Message:
> > rprocs are called from a softintr, so use kmem_intr_*
> >
> > @@ -87,7 +87,7 @@
> > npf_ext_route_t *meta;
> > const char *ifname;
> >
> > - meta = kmem_zalloc(sizeof(*meta), KM_SLEEP);
> > + meta = kmem_intr_zalloc(sizeof(*meta), KM_SLEEP);
> > ifname = nvlist_get_string(params, "route-interface");
> >
> > if (!ifname)
>
> This cannot be correct. Please revert this change and file a PR for
> the issue.
I took a closer look and I don't see how the ctor/dtor functions can
be called from intr or softintr context, so when you file a PR for
whatever issue you were trying to fix by this change, please make sure
to include the stack trace from the crash that presumably led you
here.
Home |
Main Index |
Thread Index |
Old Index