Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/share/man/man4



On Sat, Aug 29, 2026 at 11:33 PM Valery Ushakov <uwe%stderr.spb.ru@localhost> wrote:
>
> On Sat, Aug 29, 2026 at 19:27:19 +0000, Andrius Varanavicius wrote:
>
> > Module Name:  src
> > Committed By: andvar
> > Date:         Sat Aug 29 19:27:19 UTC 2026
> >
> > Modified Files:
> >       src/share/man/man4: virtio.4
> >
> > Log Message:
> > virtio(4): combine virtio and virtio_mmio man pages.
> >
> > While here, add missing VirtIO devices and improve grammar and text.
> >
> > virtio_mmio.4 was present in the source tree but never installed.
>
> I think any mentions of vritio_mmio (i.e. the attachmnt) should be
> g/c'ed from the text.  The merged result is very confusing otherwise,
> b/c it names a thing (".Nm virtio_mmio") that doesn't actually exist
> the same way virtio(4) (i.e. the driver) does.
>
> And the combined page still refers to _both_ virtio_mmio(4) and
> virtio(4) that is now the smae page - which is additionally confusing.
>
> Please, can you add a bit of final touches to the text?
>
> -uwe

Hi,

I agree that virtio_mmio should be removed to reduce confusion,since
both virtio over PCI and virtio over MMIO are attached as virtio.

I merged mmio part without expanding on pci transport, so I suppose
the combined section still feels a bit detached.

I believe at least one sentence is missing before the "virtio_mmio can
be used in virtual environments..." sentence.

I think I will sleep on it and work on the text tomorrow once I have some time.

Thanks for comments.

Regards,
Andrius V


Home | Main Index | Thread Index | Old Index