Re: CVS commit: src/sys/uvm

[Valery Ushakov <uwe%stderr.spb.ru@localhost>]

On Mon, Jul 06, 2026 at 00:14:59 +0900, Takashi YAMAMOTO wrote:

> @@ -900,7 +897,7 @@ uvm_swap_stats(char *ptr, int misc,
>         error = 0;
>         count = 0;
>         sp = sdps;
> -       while (misc-- > 0) {
> +       while (misc --> 0) {
> 
> this style change is quite surprising to me. it it intentional?

That's a "cute" way to write it so that you can read "-->" as "down to".
I'd rather see that written as a boring for-loop.


> On Sat, Jun 27, 2026 at 11:59 PM Taylor R Campbell <riastradh%netbsd.org@localhost> wrote:
> >
> > Module Name:    src
> > Committed By:   riastradh
> > Date:           Sat Jun 27 14:56:29 UTC 2026
> >
> > Modified Files:
> >         src/sys/uvm: uvm_swap.c
> >
> > Log Message:
> > uvm(9): Fix comments on swap encryption and tidy various whitespace.
> >
> > No functional change intended: comments and whitespace only.
> >
> > Cleanup after various fixes for:
> >
> > PR kern/60082: swap encryption corrupt data
> > PR kern/60083: swap encryption break /dev/drum
> > PR kern/60084: swap encryption: per-page tracking seems overengineered
> >
> >
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.233 -r1.234 src/sys/uvm/uvm_swap.c
> >
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
> >

-uwe