Re: CVS commit: src/sys/arch

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

With this change, my HP Envy 14 gets crash during boot.
I cannot get the message yet.

I have `no options PCI_RESOURCE` in my kernel config file
and my kernel does not crash anymore on HP Envy 14.

Is this change really safe for any machines?

Thank you.


"Taylor R Campbell" <riastradh%netbsd.org@localhost> writes:

> Module Name:	src
> Committed By:	riastradh
> Date:		Thu Jul  2 17:56:50 UTC 2026
>
> Modified Files:
> 	src/sys/arch/amd64/conf: GENERIC
> 	src/sys/arch/i386/conf: GENERIC
>
> Log Message:
> x86/GENERIC: Enable PCI_RESOURCE.
>
> Has been needed for motherboards that are already several years old
> by now, which require the OS to allocate PCI memory regions for some
> devices like iwm(4); let's get some experience with having it on by
> default.
>
> PR port-amd64/59118: Thinkpad T495s - iwm PCI BAR is zero
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.621 -r1.622 src/sys/arch/amd64/conf/GENERIC
> cvs rdiff -u -r1.1262 -r1.1263 src/sys/arch/i386/conf/GENERIC
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
> Modified files:
>
> Index: src/sys/arch/amd64/conf/GENERIC
> diff -u src/sys/arch/amd64/conf/GENERIC:1.621 src/sys/arch/amd64/conf/GENERIC:1.622
> --- src/sys/arch/amd64/conf/GENERIC:1.621	Fri Feb 20 07:54:26 2026
> +++ src/sys/arch/amd64/conf/GENERIC	Thu Jul  2 17:56:49 2026
> @@ -1,4 +1,4 @@
> -# $NetBSD: GENERIC,v 1.621 2026/02/20 07:54:26 yamt Exp $
> +# $NetBSD: GENERIC,v 1.622 2026/07/02 17:56:49 riastradh Exp $
>  #
>  # GENERIC machine description file
>  #
> @@ -22,7 +22,7 @@ include 	"arch/amd64/conf/std.amd64"
>  
>  options 	INCLUDE_CONFIG_FILE	# embed config file in kernel binary
>  
> -#ident		"GENERIC-$Revision: 1.621 $"
> +#ident		"GENERIC-$Revision: 1.622 $"
>  
>  maxusers	64		# estimated number of users
>  
> @@ -320,7 +320,7 @@ acpi0		at mainbus0
>  options 	ACPI_SCANPCI		# find PCI roots using ACPI
>  options 	MPBIOS			# configure CPUs and APICs using MPBIOS
>  options 	MPBIOS_SCANPCI		# MPBIOS configures PCI roots
> -#options 	PCI_RESOURCE		# Allocate unconfigured PCI resources
> +options 	PCI_RESOURCE		# Allocate unconfigured PCI resources
>  #options 	PCI_INTR_FIXUP		# fixup PCI interrupt routing via ACPI
>  #options 	PCI_BUS_FIXUP		# fixup PCI bus numbering
>  #options 	PCI_ADDR_FIXUP		# fixup PCI I/O addresses
>
> Index: src/sys/arch/i386/conf/GENERIC
> diff -u src/sys/arch/i386/conf/GENERIC:1.1262 src/sys/arch/i386/conf/GENERIC:1.1263
> --- src/sys/arch/i386/conf/GENERIC:1.1262	Fri Feb 20 07:54:26 2026
> +++ src/sys/arch/i386/conf/GENERIC	Thu Jul  2 17:56:49 2026
> @@ -1,4 +1,4 @@
> -# $NetBSD: GENERIC,v 1.1262 2026/02/20 07:54:26 yamt Exp $
> +# $NetBSD: GENERIC,v 1.1263 2026/07/02 17:56:49 riastradh Exp $
>  #
>  # GENERIC machine description file
>  #
> @@ -22,7 +22,7 @@ include 	"arch/i386/conf/std.i386"
>  
>  options 	INCLUDE_CONFIG_FILE	# embed config file in kernel binary
>  
> -#ident		"GENERIC-$Revision: 1.1262 $"
> +#ident		"GENERIC-$Revision: 1.1263 $"
>  
>  maxusers	64		# estimated number of users
>  
> @@ -414,7 +414,7 @@ pci*	at elansc? bus ?
>  					# on anything else.
>  #options 	PCIINTR_DEBUG		# super-verbose PCI interrupt fixup
>  
> -#options 	PCI_RESOURCE		# Allocate unconfigured PCI resources
> +options 	PCI_RESOURCE		# Allocate unconfigured PCI resources
>  
>  # PCI fixups, for both PCIBIOS and ACPI
>  #options 	PCI_ADDR_FIXUP		# fixup PCI I/O addresses
>

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3