Re: CVS commit: src/sys/net

[Shoichi Yamaguchi <yamaguchi%netbsd.org@localhost>]

On Wed, Jun 24, 2026 at 8:15 PM Martin Husemann <martin%netbsd.org@localhost> wrote:
>
> On Wed, Jun 24, 2026 at 06:56:04AM +0000, Shoichi YAMAGUCHI wrote:
> > Module Name:  src
> > Committed By: yamaguchi
> > Date:         Wed Jun 24 06:56:04 UTC 2026
> >
> > Modified Files:
> >       src/sys/net: if_spppsubr.c
> >
> > Log Message:
> > sppp: use atomic_loadstore(9) to read and write sp->pp_last_activity
> >
> >
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.292 -r1.293 src/sys/net/if_spppsubr.c
>
> Sorry, but this breaks the build:
>
> /work/src/sys/rump/net/lib/libnet/../../../../net/if_spppsubr.c: In function 'sp
> pp_keepalive':
> /work/src/sys/rump/net/lib/libnet/../../../../sys/atomic.h:427:9: note: in expansion of macro 'CTASSERT'
>   427 |         CTASSERT(sizeof(*(p)) <= __ATOMIC_SIZE_MAX);                          \
>       |         ^~~~~~~~
>
> We do not have 64bit atomics on all architectures.
>
> Does this have to be a 64bit value?
>
> Martin

I apologize for my mistake and for not checking the build. Thank you
so much for the fix, riastradh@.

-- Yamaguchi