Re: CVS commit: src

[christos%astron.com@localhost (Christos Zoulas)]

In article <20251204182217.EA2C9F995%cvs.NetBSD.org@localhost>,
Nia Alarie <source-changes-d%NetBSD.org@localhost> wrote:
>-=-=-=-=-=-
>
>Module Name:	src
>Committed By:	nia
>Date:		Thu Dec  4 18:22:17 UTC 2025
>
>Modified Files:
>	src: BUILDING
>	src/distrib/sets/lists/man: mi
>	src/doc: BUILDING.mdoc
>	src/external/gpl2: Makefile
>	src/share/man/man5: mk.conf.5
>	src/share/mk: bsd.own.mk
>	src/usr.bin: Makefile
>Added Files:
>	src/usr.bin/diff: Makefile diff.1 diff.c diff.h diffdir.c diffdir.h
>	    diffreg.c pr.c pr.h xmalloc.c xmalloc.h
>	src/usr.bin/diff3: Makefile diff3.1 diff3.c
>
>Log Message:
>Import BSD-licensed diff from FreeBSD to replace GNU diffutils
>
>Ported to NetBSD, compiler warnings fixed, and some unnecessary
>features (for the purpose of replacing our GPLv2 diff) have been
>stripped out.
>
>Non-default at the moment, requires building with MKBSDDIFF=yes.
>
>PR bin/59798 We are still using GNU diffutils

Wouldn't it have been better for future maintainability to import the
unmodified FreeBSD sources in a vendor branch (or a separate commit)
and then apply our changes on top?

christos