Re: CVS commit: src/external/gpl3/gcc.old/lib

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

Hi,

On 2025/09/27 21:44, Christos Zoulas wrote:
> In article <20250926104101.19511F995%cvs.NetBSD.org@localhost>,
> Rin Okuyama <source-changes-d%NetBSD.org@localhost> wrote:
> > -=-=-=-=-=-
> >
> > Module Name:	src
> > Committed By:	rin
> > Date:		Fri Sep 26 10:41:00 UTC 2025
> >
> > Modified Files:
> > 	src/external/gpl3/gcc.old/lib: Makefile.sanitizer
> >
> > Log Message:
> > gcc.old: vax: G/C unnecessary -O1 hacks for sanitizer
> >
> > Sanitizers successfully build, and all ATF cases for ubsan pass
> > without these hacks for vax.
> >
> >
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.8 -r1.9 src/external/gpl3/gcc.old/lib/Makefile.sanitizer
> >
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
> >
> >
> > -=-=-=-=-=-
> >
> > Modified files:
> >
> > Index: src/external/gpl3/gcc.old/lib/Makefile.sanitizer
> > diff -u src/external/gpl3/gcc.old/lib/Makefile.sanitizer:1.8
> > src/external/gpl3/gcc.old/lib/Makefile.sanitizer:1.9
> > --- src/external/gpl3/gcc.old/lib/Makefile.sanitizer:1.8	Sun Sep  7
> > 04:11:47 2025
> > +++ src/external/gpl3/gcc.old/lib/Makefile.sanitizer	Fri Sep 26 10:41:00 2025
> > @@ -1,4 +1,4 @@
> > -#	$NetBSD: Makefile.sanitizer,v 1.8 2025/09/07 04:11:47 mrg Exp $
> > +#	$NetBSD: Makefile.sanitizer,v 1.9 2025/09/26 10:41:00 rin Exp $
> >
> > SANITIZER=${GCCDIST}/libsanitizer
> > .PATH: ${SANITIZER}/interception ${SANITIZER}/sanitizer_common
> > @@ -104,22 +104,3 @@ COPTS.ubsan_handlers_cxx.cpp+=-Wno-error
> >
> > # Can't profile without it
> > #-fomit-frame-pointer
> > -
> > -.if ${MACHINE_ARCH} == "vax"
> > -COPTS.sanitizer_allocator.cc += -O1
> > -COPTS.sanitizer_common.cc += -O1
> > -COPTS.sanitizer_common_libcdep.cc += -O1
> > -COPTS.sanitizer_coverage_libcdep.cc += -O1
> > -COPTS.sanitizer_coverage_mapping_libcdep.cc += -O1
> > -COPTS.sanitizer_deadlock_detector1.cc += -O1
> > -COPTS.sanitizer_mac.cc += -O1
> > -COPTS.sanitizer_netbsd.cc += -O1
> > -COPTS.sanitizer_posix.cc += -O1
> > -COPTS.sanitizer_printf.cc += -O1
> > -COPTS.sanitizer_procmaps_common.cc += -O1
> > -COPTS.sanitizer_stackdepot.cc += -O1
> > -COPTS.sanitizer_symbolizer_libcdep.cc += -O1
> > -COPTS.sanitizer_symbolizer_report.cc += -O1
> > -COPTS.ubsan_diag.cc += -O1
> > -COPTS.ubsan_init.cc += -O1
> > -.endif
>
> Aren't those still needed, because presumably when you are building
> gcc.old, you end up with a gcc that needs them?

I've confirmed these are needless for HAVE_GCC=12 build.

These should have been removed no later than switching to
GCC12, but we missed at that time ;)

Thanks,
rin

> christos