Re: CVS commit: src/external/mit/xorg/lib/libXfont

[christos%astron.com@localhost (Christos Zoulas)]

In article <20250706064759.7316BF99C%cvs.NetBSD.org@localhost>,
Nathanial Sloss <source-changes-d%NetBSD.org@localhost> wrote:
>-=-=-=-=-=-
>
>Module Name:	src
>Committed By:	nat
>Date:		Sun Jul  6 06:47:59 UTC 2025
>
>Modified Files:
>	src/external/mit/xorg/lib/libXfont: Makefile
>
>Log Message:
>Sprinkle -fno-stack-protector.
>
>Fixes issue with SSP and m68k.
>The same was done earlier by rin@ for Xfont2.
>
>Addresses PR port-m68k/59508.
>
>
>To generate a diff of this commit:
>cvs rdiff -u -r1.13 -r1.14 src/external/mit/xorg/lib/libXfont/Makefile
>
>Please note that diffs are not public domain; they are subject to the
>copyright notices on the relevant files.
>
>
>-=-=-=-=-=-
>
>Modified files:
>
>Index: src/external/mit/xorg/lib/libXfont/Makefile
>diff -u src/external/mit/xorg/lib/libXfont/Makefile:1.13
>src/external/mit/xorg/lib/libXfont/Makefile:1.14
>--- src/external/mit/xorg/lib/libXfont/Makefile:1.13	Tue Nov 16 09:25:51 2021
>+++ src/external/mit/xorg/lib/libXfont/Makefile	Sun Jul  6 06:47:59 2025
>@@ -1,4 +1,4 @@
>-#	$NetBSD: Makefile,v 1.13 2021/11/16 09:25:51 nia Exp $
>+#	$NetBSD: Makefile,v 1.14 2025/07/06 06:47:59 nat Exp $
> 
> USE_FORT?=	yes # data-driven bugs?
> 
>@@ -70,5 +70,9 @@ PKGDIST=	${LIB}
> CWARNFLAGS.clang+=	-Wno-tautological-compare -Wno-string-plus-int
> COPTS.ftfuncs.c+=	${${ACTIVE_CC} == "gcc" && ${HAVE_GCC:U0} >= 10:?
>-Wno-error=overflow :}
> 
>+.if ${HAVE_GCC:U0} >= 12 && ${MACHINE_ARCH} == "m68k"
>+COPTS.fontxlfd.c+=	-fno-stack-protector
>+.endif
>+
> .include <bsd.x11.mk>
> .include <bsd.lib.mk>

Is that a permanent thing? Should it be mentioned in HACKS? Is it a compiler
bug?

Thanks,
christos