Re: CVS commit: src/sys/dev/pci

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

> Module Name:    src
> Committed By:   joe
> Date:           Tue Feb 25 02:10:13 UTC 2025
> 
> Modified Files:
>         src/sys/dev/pci: if_iavf.c
> 
> Log Message:
> initialize post to 0
> 
> this prevents the use of unitialized variable when we hit an error branch
> on the first attempt/iteration that will cause it to break out of the do while
> loop

Nice catch.  This looks like it warrants pullup to netbsd-10, where
the bug is still there.  Have you requested a pullup?

Even though it may seem like a small change doesn't need a bug report,
I suggest you file one in gnats anyway to track the answer to this
question.  Just a quick blurb with enough detail to identify the
problem:

>Description: uninitialized variable `post' in iavf_rxfill used
>  unconditionally after the loop
>  https://nxr.netbsd.org/xref/src/sys/dev/pci/if_iavf.c?r=1.18#2572
>How-to-repeat: code inspection

And then say `PR kern/NNNNN' (whatever NNNNN is assigned) in the
commit message.  That way, when I come across this change while
reviewing source-changes, I can open up https://gnats.NetBSD.org/NNNNN
to track pullups for it, and we can close the PR when the change has
been pulled up.