Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/external



In article <20240405085127.B998EFA2C%cvs.NetBSD.org@localhost>,
Robert Elz <source-changes-d%NetBSD.org@localhost> wrote:
>Module Name:	src
>Committed By:	kre
>Date:		Fri Apr  5 08:51:27 UTC 2024
>
>Modified Files:
>	src/external: Makefile
>	src/external/mit/libuv/lib: Makefile
>
>Log Message:
>Probable hack fix for current build breakage.
>
>Make sure to build external/mit before external/mpl (as bind in mpl
>needs libuv from mit) and in mit/libuv make sure to build the
>static library with the new MAKESTATICLIB mechanism, as that is
>what bind needs.

Thanks for fixing. The Makefile in external does not handle dependencies
and I don't think it gets invoked until libraries have been built, which
in src/lib/Makefile handles the mit/uv mpl/bind order. The change you
made is fine, I will make the line shorter. The libuv Makefile change is
ok too, but it is simplere to just not build the pic library in the first
place, which is what I have done.

christos



Home | Main Index | Thread Index | Old Index