> On Jul 31, 2023, at 3:11 PM, matthew green <mrg%eterna.com.au@localhost> wrote: > >> Don't call versioned stuff "old". Follow the naming convention for versioning >> and name them after the last version of the OS they appeared on. > > won't this break, eg, external sanitizer consumers? please restore the > old names. they're public and should remain public. Who are the external sanitizer consumers? Nothing uses those things; they are there for binary compatibility. Nothing should be referring to those names. I had to look in the CVS logs to find out the last version of NetBSD that they were used in order to figure out what to call them. I even don't understand why the sanitizers have them (we should probably delete them so that they are not a maintenance hassle). It is not like someone will compile new code that will use the old ioctls?!?!? So how are they useful in a sanitizer context? The next step is to move them to compat/ so that they don't litter the standard headers and code. This is simply ancient compat stuff that was written before we had better ways to do things. christos
Attachment:
signature.asc
Description: Message signed with OpenPGP