Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Detecting typos in makefiles (was: Re: CVS commit: src/share/mk)



On Sun, 15 Jan 2023 19:14:14 +0100, Roland Illig writes:
>It is really unfortunate that make didn't catch this typo by itself.
>
>.if ${MACHINE_ARCH} =3D=3D "x86_64" || \
>     ${MACHINE_ARCH} =3D=3D "i386" || \
>     ${MACHINE_ARCH} =3D=3D "alpha" || \\
>     !empty(MACHINE_ARCH:Maarch64*) || \
>     !empty(MACHINE_ARCH:Msparc*)
>
>(The 'alpha' line has a trailing '\\' instead of the usual '\'.)

Yes warnings would be good I think.

FWIW the above is why I encouage use of :N to reduce the complexity of
conditionals (eaier to extend without screwing up) as in:

.if ${MACHINE_ARCH:Nalpha:Ni386:Nx86_64} == ""

is equivalent to the first 3 lines above.


Home | Main Index | Thread Index | Old Index