Re: CVS commit: src

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

> Module Name:	src
> Committed By:	nat
> Date:		Thu Dec 22 11:05:55 UTC 2022
> 
> Modified Files:
> 	src/distrib/sets/lists/man: mi
> 	src/share/man/man4: Makefile
> 	src/sys/arch/alpha/conf: GENERIC
> 	src/sys/arch/amd64/conf: ALL
> 	src/sys/arch/atari/conf: ATARITT FALCON GENERIC.in HADES HADES.in
> 	src/sys/arch/i386/conf: ALL
> 	src/sys/arch/mac68k/conf: GENERIC
> 	src/sys/arch/next68k/conf: GENERIC SLAB
> 	src/sys/dev/scsipi: files.scsipi
> Added Files:
> 	src/share/man/man4: dse.4
> 	src/sys/dev/scsipi: if_dse.c
> 
> Log Message:
> Driver for DaynaPORT SCSI/Link (dse.4).
> 
> Written by Hiroshi Noguchi, of which an updated version was posted to
> port-mac68k in 2001.
> 
> Attachments were added to kernel configs for platforms that already had
> the Cabletron (se.4) driver added, although other platorms may benefit.
> 
> Reviewed on tech-net by Izumi Tsutsui.

Well it would be better to put some ack for a comment,
to call it "reviewd".

>> static int
>> dse_read(struct dse_softc *sc, uint8_t *data, int datalen)
>> {
  :
>> 			if_statinc(ifp, if_ierrors);
>> printf("LEN %d\n",len);
 : 
>> printf("M null\n");
>> 			if_statinc(ifp, if_ierrors);
>> 			goto next_packet;
>> 		}

Looks stray debug printfs.

>> static int
>> dse_ioctl(struct ifnet *ifp, u_long cmd, void *data)
>> {
 :
>> 		case AF_INET:
>> 	//		sc->protos |= (PROTO_IP | PROTO_ARP | PROTO_REVARP);
 :
>>		case AF_APPLETALK:
>> 	//		sc->protos |= (PROTO_AT | PROTO_AARP);

Looks no protos member in the dse_softc so not necessary?

>> #ifdef SEDEBUG

Is this SEDEBUG intentional or leftover?

---
Izumi Tsutsui