Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev



> Date: Tue, 04 Oct 2022 15:53:58 +0900
> From: Ryo ONODERA <ryo%tetera.org@localhost>
> 
> With this patch, it works fine for me.
> There is no stall after genfb(4).
> And I do not find any other problem so far.

Thanks!  There probably is another problem which is that kernel
console printfs might stop appearing after a certain point, which the
following patch might fix too -- I inadvertently reversed the sense
of a conditional in the subr_prf.c changes.
From 0f058a0e89e3f545a9020a2fb79dadd7ad89029a Mon Sep 17 00:00:00 2001
From: Taylor R Campbell <riastradh%NetBSD.org@localhost>
Date: Tue, 4 Oct 2022 05:48:39 +0000
Subject: [PATCH] squash! constty(4): Make MP-safe.

- Fix reversed sense of conditional.
---
 sys/kern/subr_prf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/kern/subr_prf.c b/sys/kern/subr_prf.c
index e87e6efc8501..53fb20c1d393 100644
--- a/sys/kern/subr_prf.c
+++ b/sys/kern/subr_prf.c
@@ -425,7 +425,7 @@ putone(int c, int flags, struct tty *tp)
 	if ((flags & TOLOG) &&
 	    c != '\0' && c != '\r' && c != 0177)
 	    	logputchar(c);
-	if ((flags & TOCONS) && ctp != NULL && c != '\0')
+	if ((flags & TOCONS) && ctp == NULL && c != '\0')
 		(*v_putc)(c);
 
 	pserialize_read_exit(s);


Home | Main Index | Thread Index | Old Index