> Date: Sun, 13 Feb 2022 05:44:38 +1100
> from: matthew green <mrg%eterna.com.au@localhost>
>
> "Roland Illig" writes:
> > Module Name: src
> > Committed By: rillig
> > Date: Fri Feb 11 21:36:46 UTC 2022
> >
> > Modified Files:
> > src/lib/libc/stdlib: getenv.c
> >
> > Log Message:
> > libc/getenv: remove trailing whitespace
> >
> > No binary change.
>
> please avoid purely whitespace changes unless you're
> also going to be modifying the code itself.
>
> (don't back out now.)
I thought we were supposed to _avoid_ mixing whitespace changes and
functional changes?
(Obviously the solution is to just only ever commit code with perfect
style to begin with so this is never an issue! Speaking of which,
(setq show-trailing-whitespace t) is helpful to avoid this kind of
mistake up front. git diff or git add -p will also flag this kind of
mistake, if you're working in git. /usr/share/misc/NetBSD.el is also
helpful for other KNF style.)
I thought the rule was don't make purely whitespace changes UNLESS you plan on making other changes to (or are fixing an oops you just made). If that's the case, separate the two commits.
Warner