Re: CVS commit: src

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

In MKDEBUG=yes and MKDEBUG=no cases,
./build.sh kernel=LOCKDEBUG fails as follows, for example:

(snip)
#      link  LOCKDEBUG/netbsd
/usr/world/9.99/amd64/tools/bin/x86_64--netbsd-ld -Map netbsd.map --cref -T netbsd.ldscript -Ttext 0xffffffff80200000 -e start -z max-page-size=0x200000 -X -o netbsd ${SYSTEM_OBJ:[@]:Nswapnetbsd.o} ${EXTRA_OBJ} vers.o swapnetbsd.o
NetBSD 9.99.93 (LOCKDEBUG) #0: Fri Dec 31 01:31:35 JST 2021
   text    data     bss     dec     hex filename
21646842         728976 1368064 23743882        16a4d8a netbsd
+ mv -f netbsd netbsd.gdb
+ /usr/world/9.99/amd64/tools/bin/x86_64--netbsd-objcopy --only-keep-debug netbsd.gdb netbsd-/usr/src/sys/arch/amd64/conf/LOCKDEBUG.debug
/usr/world/9.99/amd64/tools/bin/x86_64--netbsd-objcopy: netbsd-/usr/src/sys/arch/amd64/conf/LOCKDEBUG.debug: No such file or directory
+ exit 1

*** Failed target: netbsd
*** Failed commands:
        ${SYSTEM_LD_HEAD}
        => @rm -f netbsd
        ${SYSTEM_LD}
        => echo '#  ' "   link  LOCKDEBUG/netbsd";  echo /usr/world/9.99/amd64/t
(snip)

My Makefile for the kernel has the following line.
Your code may expect BUILD_KERNEL as kernel configuration file name,
for example GENERIC or LOCKDEBUG in above error message.
However it is absolute path and not kernel configuration file name.

KERNEL_BUILD=/usr/src/sys/arch/amd64/conf/LOCKDEBUG
(snip)

I have 2 questions.
(1) In MKDEBUG=no, split-debug file for kernel is created.
    This behavior is not consistent with your commit message.
(2) You have added "./usr/libdata/debug/netbsd-CONFIG.debug ..." entry
    to src/distrib/sets/lists/debug/mi. Do you intended BUILD_KERNEL
    as constant CONFIG string?

Thank you.

"Christos Zoulas" <christos%netbsd.org@localhost> writes:

> Module Name:	src
> Committed By:	christos
> Date:		Wed Dec 29 22:22:13 UTC 2021
>
> Modified Files:
> 	src: build.sh
> 	src/distrib/sets: sets.subr
> 	src/distrib/sets/lists/debug: mi
> 	src/etc: Makefile
> 	src/sys/conf: Makefile.kern.inc
>
> Log Message:
> Enable split-debug files for kernels. Enabled by default with MKDEBUG=yes.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.359 -r1.360 src/build.sh
> cvs rdiff -u -r1.197 -r1.198 src/distrib/sets/sets.subr
> cvs rdiff -u -r1.369 -r1.370 src/distrib/sets/lists/debug/mi
> cvs rdiff -u -r1.455 -r1.456 src/etc/Makefile
> cvs rdiff -u -r1.285 -r1.286 src/sys/conf/Makefile.kern.inc
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3