Re: CVS commit: src/sys/arch

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Sun, 31 Oct 2021 16:23:48 +0000
Nick Hudson <skrll%netbsd.org@localhost> wrote:

> Modified Files:
> 	src/sys/arch/aarch64/include: cpu.h cpufunc.h db_machdep.h
...
> Log Message:
> Rework Arm (32bit and 64bit) AP startup so that cpu_hatch doesn't sleep.

Hi,

I'm afraid this broke the userland build.
I think db_machdep_init(...) should move to the ifdef _KERNEL block?

   compile  crash/db_autoconf.o
In file included from /usr/src/../obj/usr.sbin/crash/machine/db_machdep.h:4,
                 from /usr/src/usr.sbin/crash/../../sys/ddb/ddb.h:35,
                 from /usr/src/usr.sbin/crash/../../sys/ddb/db_autoconf.c:39:
/usr/src/../obj/usr.sbin/crash/aarch64/db_machdep.h:231:29: error: 'struct cpu_info' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
  231 | void db_machdep_init(struct cpu_info * const);

-Tobias