Re: CVS commit: src/usr.sbin/rpcbind

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

On 2021/10/30 20:04, Nia Alarie wrote:
> This function
> previously tried to go to a label that doesn't exist. I wonder why
> GCC didn't catch this before but does now.

This is not true. You deleted the label:

> -		if (p == NULL) {
> -out:
> -			syslog(LOG_ERR, "Cannot allocate pollfds");
> -			sleep(1);
> -			continue;
> -		}
>   		if ((m = svc_fdset_getmax()) == NULL)
> -			goto out;
> +			break;

We should not break from infinite loop here, even if svc_fdset_getmax()
fails. Please restore the old behavior. And please be more careful before
making such a non-trivial change.

Thanks,
rin