re: CVS commit: src/sbin/wsconsctl

[matthew green <mrg%eterna.com.au@localhost>]

Rin Okuyama writes:
> I don't think this is right thing to be committed.

i agree.

> By this way, we can add similar LINTFLAGS hacks every when
> kernel API is changed.
>
> Please keep this kinds of hacks within your local repository.
>
> > Running lint in non-tools mode picked up the header from the installed
> > system, not the one corresponding to the source code. The installed
> > header on NetBSD 9.99.88 does not define WSMOUSECFG_MAX yet.

i would go far to say that the above behaviour is 100%
_expected_.  if you're building in non tools mode then you
are using the installed system, and not using it would be
not how this has always worked.  this is why, whether you're
using build.sh or not, "make includes" early is a necessary
pre-condition for building.

> Thanks,
> rin


.mrg.

> On 2021/10/11 22:27, Roland Illig wrote:
> > Module Name:	src
> > Committed By:	rillig
> > Date:		Mon Oct 11 13:27:47 UTC 2021
> > 
> > Modified Files:
> > 	src/sbin/wsconsctl: Makefile
> > 
> > Log Message:
> > wsconsctl: include correct header for lint
> > 
> > Running lint in non-tools mode picked up the header from the installed
> > system, not the one corresponding to the source code. The installed
> > header on NetBSD 9.99.88 does not define WSMOUSECFG_MAX yet.