Re: CVS commit: src/bin/sh

[Tom Ivar Helbekkmo <tih%hamartun.priv.no@localhost>]

Roland Illig <roland.illig%gmx.de@localhost> writes:

> Anyway, the code in question was more verbose than necessary, so I made
> it simpler. I also experimented with replacing the switch with a single
> if statement, but that would have become too dense and thus difficult to
> decipher.

Yes, the code in exec.c looks much better now.  The do .. while (0)
construct in jobs.c, however, looks like it could be improved by
removing the 'do' and 'while (0)' lines altogether, including the
misleading comment on the 'do' line.  That would also pull the goto
target 'out' one level up, making its context less confusing.

-tih
-- 
Most people who graduate with CS degrees don't understand the significance
of Lisp.  Lisp is the most important idea in computer science.  --Alan Kay