Re: CVS commit: src/sys

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

Hi,

On 2021/09/11 19:09, Taylor R Campbell wrote:
> Module Name:	src
> Committed By:	riastradh
> Date:		Sat Sep 11 10:09:55 UTC 2021
>
> Modified Files:
> 	src/sys/arch/sparc64/sparc64: machdep.c
> 	src/sys/kern: kern_ksyms.c subr_csan.c subr_msan.c
> 	src/sys/sys: ksyms.h
>
> Log Message:
> ksyms: Use pserialize(9) for kernel access to ksyms.
>
> This makes it available in interrupt context, e.g. for printing
> messages with kernel symbol names for return addresses as drm wants
> to do.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.302 -r1.303 src/sys/arch/sparc64/sparc64/machdep.c
> cvs rdiff -u -r1.103 -r1.104 src/sys/kern/kern_ksyms.c
> cvs rdiff -u -r1.12 -r1.13 src/sys/kern/subr_csan.c
> cvs rdiff -u -r1.16 -r1.17 src/sys/kern/subr_msan.c
> cvs rdiff -u -r1.41 -r1.42 src/sys/sys/ksyms.h
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

kern_ksyms.c rev 1.104 causes this on landisk (sh3):

----
Checking for core dump...
savecore: (null): kvm_nlist: bad namelist
Sep 15 19:03:53 hdlu savecore: (null): kvm_nlist: bad namelist
savecore: (null): _dumpdev not in namelist
Sep 15 19:03:53 hdlu savecore: (null): _dumpdev not in namelist
Starting local daemons:.
Updating motd.
Starting ntpd.
Starting postfix.
Starting inetd.
Starting cron.
Wed Sep 15 19:04:33 JST 2021

NetBSD/landisk (hdlu) (constty)

login: [  95.5000696] panic: kernel diagnostic assertion "slock != NULL" failed: file "../../../../uvm/uvm_pdaemon.c", line 398 pg 0x8c66bd88 uobj 0x8fa7e400, NULL lock
[  95.6535669] cpu0: Begin traceback...
[  95.7031947] db_panic() at netbsd:vpanic+0xea
[  95.7500715] vpanic() at netbsd:kern_assert+0x24
[  95.7969493] kern_assert() at netbsd:uvmpd_page_owner_lock+0x56
[  95.8750798] uvmpd_page_owner_lock() at netbsd:uvmpd_trylockowner+0x3e
[  95.9531988] uvmpd_trylockowner() at netbsd:uvmpdpol_balancequeue+0x19c
[  96.0313226] uvmpdpol_balancequeue() at netbsd:uvm_pageout+0x5fa
[  96.0993345] uvm_pageout() at netbsd:lwp_trampoline+0xc
[  96.1568912] lwp_trampoline() at 0
[  96.1997961] cpu0: End traceback...
Stopped in pid 0.107 (system) at        netbsd:cpu_Debugger+0x6:        mov
r14, r15
db>
----

It seems that I can avoid this panic if

- revert kern_ksyms.c to rev 1.98 (*), *or*
- set savecore=NO in rc.conf.

(*) I've not tested revs 1.99--1.103.

Can you please take a look into?

Thanks,
rin