Re: CVS commit: src/crypto/external/bsd/openssh/dist

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

Rin Okuyama <rokuyama.rk%gmail.com@localhost> writes:

> On 2021/09/06 23:11, Ryo ONODERA wrote:
>> Hi,
>> 
>> Rin Okuyama <rokuyama.rk%gmail.com@localhost> writes:
>> 
>>> On 2021/09/06 22:11, Ryo ONODERA wrote:
>>>> Module Name:	src
>>>> Committed By:	ryoon
>>>> Date:		Mon Sep  6 13:11:34 UTC 2021
>>>>
>>>> Modified Files:
>>>> 	src/crypto/external/bsd/openssh/dist: dns.c
>>>>
>>>> Log Message:
>>>> Make no diff to upstream
>>>>
>>>>
>>>> To generate a diff of this commit:
>>>> cvs rdiff -u -r1.20 -r1.21 src/crypto/external/bsd/openssh/dist/dns.c
>>>>
>>>> Please note that diffs are not public domain; they are subject to the
>>>> copyright notices on the relevant files.
>>>
>>> This diff from upstream is intentional. See:
>>>
>>> http://cvsweb.netbsd.org/bsdweb.cgi/src/crypto/external/bsd/openssh/dist/dns.c#rev1.6
>>> http://cvsweb.netbsd.org/bsdweb.cgi/src/crypto/external/bsd/openssh/dist/dns.c#rev1.7
>> 
>> Thanks for your pointer.
>> 
>> 
>> #define timingsafe_bcmp(a, b, c) (!consttime_memequal((a), (b), (c)))
>> 
>> is in src/crypto/external/bsd/openssh/dist/includes.h.
>> 
>> My change still uses consttime_memequal() practically like
>> other places in OpenSSH.
>
> Ah, I got it. Thanks for explanation, and sorry for the noise!

Sorry for my less explanation.
I should write more information in the commit message.

Thank you.

> rin

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3