Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin



Am 20.08.2021 um 03:12 schrieb Robert Elz:
>     Date:        Thu, 19 Aug 2021 21:21:04 +0000
>     From:        "Roland Illig" <rillig%netbsd.org@localhost>
>     Message-ID:  <20210819212104.7C965FA97%cvs.NetBSD.org@localhost>
>
>   | mkdep: fix prototype of findcc
>
> That broke the build.

I'm sorry for that.  I knew that mkdep and lint were the only programs
that use this code, so I ran "make" in these directories and then tested
the programs.  What I had missed was to first run "make depend" so that
findcc.c would be rebuilt as well.

> The right thing to do is to handle the FIXME in the comment,
> and fix it, instead of enshrining it by changing the prototype.

Thank you for the idea of how to fix it properly, I just did that and
extended the existing tests as well.

Roland


Home | Main Index | Thread Index | Old Index