Re: CVS commit: src

[Andrius V <vezhlys%gmail.com@localhost>]

Hi,

Thank you for suggestions, I will take them in mind for future
commits. I believe I will avoid doing such big commits in the future
though, just I had submitted them all in my own PR some time ago... I
actually asked about the strategy in IRC and I got comment to do one
commit this time, just to check the code builds properly for those
definition changes just in case. I built few different targets (from
sh3, x86 and arm) before this commit and reviewed my commit multiple
times to ensure I am not committing something unintended (it really
took hours before I felt quite confident). However, I still seems made
a mistake by fixing several external files, noted by joerg. I believe
I changed only three definitions in total VGE_CHIPCFG1_OFFSET in
if_vgereg.h (affects if_vge.c), local variable state_override in
sctp_output.c and __PMAP_PTP_OFFSET in /sys/arch/sh3/sh3/pmap.c
(affects exception_vector.S too). The last one I am planning to revert
back, since Izumi Tsutsui noted that name follows historical PGOFSET
naming. Sorry, if this commit caused any trouble.

Regards,
Andrius V




On Mon, Jul 26, 2021 at 3:40 AM Rin Okuyama <rokuyama.rk%gmail.com@localhost> wrote:
>
> On 2021/07/25 6:31, Andrius Varanavicius wrote:
> > Module Name:  src
> > Committed By: andvar
> > Date:         Sat Jul 24 21:31:39 UTC 2021
> >
> ...
> >
> > Log Message:
> > Fix all remaining typos, mainly in comments but also in few definitions and log messages, reported by me in PR kern/54889.
> > Also fixed some additional typos in comments, found on review of same files or typos.
>
> Hi,
>
> Thank you for cleaning up a lot of typos!
>
> I'd appreciate a lot if you could separate a commit into (a) changes for
> comments, and (b) changes for macro/variable names, etc. It should be
> hard to figure out why from huge diff, if something goes wrong.
>
> Thanks,
> rin