Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/share/misc



On Wed, Mar 31, 2021 at 12:38:20PM +1100, matthew green wrote:
> i already did in the other thread -- apply the existing
> () rule.  aka, avoid it unless it helps comprehension,
> which means simple sizeof can avoid it, but anything
> slightly complex should not.  this means that all the
> fun cases will use () and the specific case i won't use
> it for is left alone (snprintf(buf, sizeof buf, ...)).

I am in favor of this, for exactly that usage (i.e. passing a buffer
and its size to a function that takes a pointer / size_t argument).
However, all cases where the paranthesis pretend a different evaluation
order should be avoided anyway.


Martin


Home | Main Index | Thread Index | Old Index