Re: CVS commit: src/usr.bin/xlint

[Valery Ushakov <uwe%stderr.spb.ru@localhost>]

On Sat, Mar 27, 2021 at 00:01:25 +0100, Roland Illig wrote:

> > > Log Message:
> > > lint: in malloc calls, use 'sizeof *ptr' instead of 'sizeof(type)'
> > 
> > style says "sizeof(" not "sizeof "
> > 
> >      * Casts and sizeof's are not followed by a space.
> 
> There are several forms of writing sizeof:
> 
> 1. sizeof expr
> 2. sizeof(expr)
> 3. sizeof (expr)
> 4. sizeof(type)
> 5. sizeof (type)
> 
> I thought that the point of the rule you cited was to discourage forms 3
> and 5.  Does the rule also discourage form 1, and if so, why?
> 
> To me, writing 'sizeof expr' is clearer than 'sizeof(expr)' since
> 'sizeof' is not a function, same as with 'return'.
> 
> Did I misinterpret the style guide in this regard?

We do want it to look like a function call (and so the usual style
rules for the function call apply).  Think of cases where it's used as
a subexpression, e.g.

    sizeof(expr) + 4

-uwe