Re: CVS commit: src/external/bsd/nvi/usr.bin/nvi

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

Hi,

This does not work since nvi requires non-standard wregex API, whose
``char *'' arguments are replaced by ``wchar_t *'' ones:

https://mail-index.netbsd.org/tech-userlevel/2008/08/06/msg000960.html
https://mail-index.netbsd.org/tech-userlevel/2008/08/06/msg000967.html

In principle, we can rewrite nvi to use standard regex API, but this
causes wide to multibyte char conversion *every time* for text search
(internal encoding of nvi is wide char). I'm not sure whether this is
acceptable for users of slow machines, who merely want to edit ASCII
texts.

Thanks,
rin

On 2021/02/26 6:56, Christos Zoulas wrote:
> Module Name:	src
> Committed By:	christos
> Date:		Thu Feb 25 21:56:35 UTC 2021
>
> Modified Files:
> 	src/external/bsd/nvi/usr.bin/nvi: Makefile
>
> Log Message:
> we don't need the extra copy wide-regex anymore.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.22 -r1.23 src/external/bsd/nvi/usr.bin/nvi/Makefile
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.