Re: CVS commit: src/usr.bin/make

[Roland Illig <roland.illig%gmx.de@localhost>]

On 26.01.2021 21:04, Christos Zoulas wrote:
> Yes, and I did not push for it for the exact reasons stated below:
> There was only a handful of cases and those can be handled with casts or a macro for now.
>
> I am questioning though the utility of maintaining compatibility with platforms that
> do not support C99 20 years later, vs. using %u and casting or using a formatting macro.

The support for ancient platforms is not only with regards to "%zu" vs.
"%u", in util.c there is even support for platforms that lack getenv().
 Apparently nobody cared enough to remove these bits, even though
getenv is guaranteed to exist since C89 already.

The code of usr.bin/make gets distributed to a wider audience by Simon's
bmake distribution (http://www.crufty.net/help/sjg/bmake.html), that's
where the requirement of supporting C89 compilers comes from.  At the
time I committed this fix, Simon had managed to dig out an old Solaris 9
installation with GCC, and these few changes were the only ones needed
to let bmake run on that platform.  That sounded easy enough to me.

Roland