Re: CVS commit: src/external/bsd/ntp/dist/ntpd

[Frank Kardel <kardel%netbsd.org@localhost>]

Hi Roy !

I doubt that the explicit draining is helpful here as it already happens

in the outer loop processing any routing socket input. All that is happening

in the routing messages processing path is to call 
timer_interfacetimeout(current_time + UPDATE_GRACE) and

this is robust for multiple calls.

Ignoring ENOBUFS was ok here due to the automatic periodic interface 
updates. calling timer_interfacetimeout(current_time + UPDATE_GRACE)

is also possible if you expect a single ENOBUFS within UPDATE_GRACE 
seconds. But there is no need o special case flushing the routing socket 
here. There is no functional improvement except for

save a few cycles in the overflow case.

Also the ntp_io system will periodically refresh it interface lists in 
time as it was explicitly designed to be robust against lost messages 
from the routing socket.

We should try to keep the differences to the up-stream code as little as 
possible. Especially when the upstream code already handles the 
situation reasonably the is no need for additional code.

Happy new year!

Frank


On 01/01/21 18:21, Roy Marples wrote:
> cvs rdiff -u -r1.27 -r1.28 src/external/bsd/ntp/dist/ntpd/ntp_io.c