Re: CVS commit: src

[Pierre Pronchery <khorben%defora.org@localhost>]

		Hi Maxime, (board@, source-changes-d@)

first of all thank you for contacting board@, as suggested by Taylor.

As I communicated to you directly a week ago, we at board@ have 
discussed the situation and asked you for the full list of files, where 
you would like to update the copyright headers.

We understand that you have already made most of the changes to the 
copyright headers that you intended, except for some files for vHCI 
support. It would be helpful to have the complete list. From what I can 
tell so far, it will include the following:

For KSAN,
- src/sys/arch/aarch64/include/asan.h
- src/sys/arch/amd64/include/asan.h
- src/sys/arch/arm/include/asan.h
- src/sys/kern/subr_asan.c
- src/sys/sys/asan.h

For KCSAN,
- src/sys/arch/amd64/include/csan.h
- src/sys/kern/subr_csan.c
- src/sys/sys/csan.h

For KMSAN,
- src/sys/arch/amd64/include/msan.h
- src/sys/kern/subr_msan.c
- src/sys/sys/msan.h

For NVMM,
- src/lib/libnvmm/libnvmm.3
- src/lib/libnvmm/libnvmm.c
- src/lib/libnvmm/libnvmm_x86.c
- src/lib/libnvmm/nvmm.h
- src/share/man/man4/nvmm.4
- src/sys/dev/nvmm/nvmm.c
- src/sys/dev/nvmm/nvmm.h
- src/sys/dev/nvmm/nvmm_internal.h
- src/sys/dev/nvmm/nvmm_ioctl.h
- src/sys/dev/nvmm/x86/nvmm_x86.c
- src/sys/dev/nvmm/x86/nvmm_x86.h
- src/sys/dev/nvmm/x86/nvmm_x86_svm.c
- src/sys/dev/nvmm/x86/nvmm_x86_svmfunc.S
- src/sys/dev/nvmm/x86/nvmm_x86_vmx.c
- src/sys/dev/nvmm/x86/nvmm_x86_vmxfunc.S
- src/tests/lib/libnvmm/h_io_assist.c
- src/tests/lib/libnvmm/h_io_assist_asm.S
- src/tests/lib/libnvmm/h_mem_assist.c
- src/tests/lib/libnvmm/h_mem_assist_asm.S
- src/tests/lib/libnvmm/t_io_assist.sh
- src/tests/lib/libnvmm/t_mem_assist.sh
- src/usr.sbin/nvmmctl/nvmmctl.8
- src/usr.sbin/nvmmctl/nvmmctl.c

Please let us know if this misses anything besides the remaining files 
for vHCI support.

Until we can fully assess the situation, we are kindly asking you to 
revert these changes, in order to restore the copyright lines as they 
were before the changes. We can then reassign the copyright back to you 
for TNF once the conditions are confirmed to allow it.

Thank you,
-- khorben for board@

On 10/09/2020 17:08, Taylor R Campbell wrote:
> > Module Name:    src
> > Committed By:   maxv
> > Date:           Sat Sep  5 07:22:26 UTC 2020
> >
> > nvmm: update copyright headers
> >
> > [...]
> > -.\" Copyright (c) 2018-2020 The NetBSD Foundation, Inc.
> > +.\" Copyright (c) 2018-2020 Maxime Villard, m00nbsd.net
> >   .\" All rights reserved.
> >   .\"
> > -.\" This code is derived from software contributed to The NetBSD Foundation
> > -.\" by Maxime Villard.
> > +.\" This code is part of the NVMM hypervisor.
>
> Please restore the NetBSD Foundation copyright notice.
>
> You can add your own copyright notice in addition to it, for copyright
> covering subsequent changes to the file, or on new files.  But you
> already committed this code to the tree years ago, and it's gone out
> in a NetBSD release with the NetBSD Foundation copyright notice.
>
> If you want TNF to reassign the copyright back to you, please contact
> board to discuss it rather than just quietly changing the existing
> copyright notice on the file in the tree.
--
khorben