Re: CVS commit: src/sys/arch/x86

[Taylor R Campbell <campbell+netbsd-source-changes-d%mumble.net@localhost>]

> Module Name:    src
> Committed By:   jdolecek
> Date:           Sat Aug  1 12:36:36 UTC 2020
> 
> Modified Files:
>         src/sys/arch/x86/pci: pci_intr_machdep.c
>         src/sys/arch/x86/x86: mainbus.c
> 
> Log Message:
> reorder includes to pull __HAVE_PCI_MSI_MSIX properly via
> <x86/pci_machdep_common.h>

If <x86/pci_machdep_common.h> requires a file to be included
("opt_pci.h"?) in order for its definition of __HAVE_PCI_MSI_MSIX to
work, why doesn't <x86/pci_machdep_common.h> include that file
directly?

Or, if I didn't follow exactly what's going on here, why is it
necessary to reorder the includes?

I think we should generally treat it as a bug if including two header
files in different orders gives different outcomes, and fix it by
fixing the header files rather than by adjusting the ordering of
includes in every file where they're used.