Re: CVS commit: src/sys/arch/x86/acpi

[Yorick Hardy <yorickhardy%gmail.com@localhost>]

Dear Andrew,

On 2020-03-14, Andrew Doran wrote:
> Module Name:	src
> Committed By:	ad
> Date:		Sat Mar 14 13:50:46 UTC 2020
> 
> Modified Files:
> 	src/sys/arch/x86/acpi: acpi_cpu_md.c
> 
> Log Message:
> Put ACPI idle under ACPICPU_ENABLE_C3 until the wrinkles are ironed out.
> This seems well written and basically all good, but currently doesn't enter
> a low power state, and imposes a big performance penalty.  Proposed on
> port-i386 & port-amd64.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.81 -r1.82 src/sys/arch/x86/acpi/acpi_cpu_md.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

This change seems to cause my machine to hang while booting. Reverting
the change seems to fix the problem. Here are the details:

  $ cpuctl identify 0
  cpu0: highest basic info 00000005
  cpu0: highest extended info 8000001b
  cpu0: "AMD Athlon(tm) II X3 450 Processor"
  cpu0: AMD Family 10h (686-class), 3200.22 MHz
  cpu0: family 0x10 model 0x5 stepping 0x3 (id 0x100f53)
  cpu0: features 0x178bfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE>
  cpu0: features 0x178bfbff<MCA,CMOV,PAT,PSE36,CLFLUSH,MMX,FXSR,SSE,SSE2,HTT>
  cpu0: features1 0x802009<SSE3,MONITOR,CX16,POPCNT>
  cpu0: features2 0xefd3fbff<SYSCALL/SYSRET,NOX,MMXX,MMX,FXSR,FFXSR,P1GB,RDTSCP>
  cpu0: features2 0xefd3fbff<LONG,3DNOW2,3DNOW>
  cpu0: features3 0x37ff<LAHF,CMPLEGACY,SVM,EAPIC,ALTMOVCR0,LZCNT,SSE4A>
  cpu0: features3 0x37ff<MISALIGNSSE,3DNOWPREFETCH,OSVW,IBS,SKINIT,WDT>
  cpu0: I-cache 64KB 64B/line 2-way, D-cache 64KB 64B/line 2-way
  cpu0: L2 cache 512KB 64B/line 16-way
  cpu0: ITLB 32 4KB entries fully associative, 16 2MB entries fully associative
  cpu0: DTLB 48 4KB entries fully associative, 48 2MB entries fully associative
  cpu0: L2 ITLB 512 4KB entries 4-way
  cpu0: L2 DTLB 512 4KB entries 4-way, 128 2MB entries 2-way
  cpu0: L1 1GB page DTLB 48 1GB entries fully associative
  cpu0: L2 1GB page DTLB 16 1GB entries 8-way
  cpu0: Initial APIC ID 0
  cpu0: Cluster/Package ID 0
  cpu0: Core ID 0
  cpu0: SMT ID 0
  cpu0: MONITOR/MWAIT extensions 0x3<EMX,IBE>
  cpu0: monitor-line size 64
  cpu0: AMD Power Management features: 0x1f9<TS,TTP,HTC,STC,100,HWP,TSC>
  cpu0: SVM Rev. 1
  cpu0: SVM NASID 64
  cpu0: SVM features 0xf<NP,LbrVirt,SVML,NRIPS>
  cpu0: UCode version: 0x10000c8
  
  $ dmesg | fgrep acpicpu
  [     1.014781] acpicpu0 at cpu0: ACPI CPU
  [     1.014781] acpicpu0: C1: HLT, lat   0 us, pow     0 mW
  [     1.014781] acpicpu0: P0: FFH, lat   4 us, pow 34375 mW, 3200 MHz
  [     1.014781] acpicpu0: P1: FFH, lat   4 us, pow 25245 mW, 2500 MHz
  [     1.014781] acpicpu0: P2: FFH, lat   4 us, pow 22200 mW, 2000 MHz
  [     1.014781] acpicpu0: P3: FFH, lat   4 us, pow 12095 mW,  800 MHz
  [     1.014781] acpicpu0: T0: I/O, lat   1 us, pow     0 mW, 100 %
  [     1.014781] acpicpu0: T1: I/O, lat   1 us, pow     0 mW,  88 %
  [     1.014781] acpicpu0: T2: I/O, lat   1 us, pow     0 mW,  76 %
  [     1.014781] acpicpu0: T3: I/O, lat   1 us, pow     0 mW,  64 %
  [     1.014781] acpicpu0: T4: I/O, lat   1 us, pow     0 mW,  52 %
  [     1.014781] acpicpu0: T5: I/O, lat   1 us, pow     0 mW,  40 %
  [     1.014781] acpicpu0: T6: I/O, lat   1 us, pow     0 mW,  28 %
  [     1.014781] acpicpu0: T7: I/O, lat   1 us, pow     0 mW,  16 %
  [     1.014781] acpicpu1 at cpu1: ACPI CPU
  [     1.014781] acpicpu2 at cpu2: ACPI CPU
  [     1.017385] acpicpu0 at cpu0: ACPI CPU
  [     1.017385] acpicpu0: C1: HLT, lat   0 us, pow     0 mW
  [     1.017385] acpicpu0: P0: FFH, lat   4 us, pow 34375 mW, 3200 MHz
  [     1.017385] acpicpu0: P1: FFH, lat   4 us, pow 25245 mW, 2500 MHz
  [     1.017385] acpicpu0: P2: FFH, lat   4 us, pow 22200 mW, 2000 MHz
  [     1.017385] acpicpu0: P3: FFH, lat   4 us, pow 12095 mW,  800 MHz
  [     1.017385] acpicpu0: T0: I/O, lat   1 us, pow     0 mW, 100 %
  [     1.017385] acpicpu0: T1: I/O, lat   1 us, pow     0 mW,  88 %
  [     1.017385] acpicpu0: T2: I/O, lat   1 us, pow     0 mW,  76 %
  [     1.017385] acpicpu0: T3: I/O, lat   1 us, pow     0 mW,  64 %
  [     1.017385] acpicpu0: T4: I/O, lat   1 us, pow     0 mW,  52 %
  [     1.017385] acpicpu0: T5: I/O, lat   1 us, pow     0 mW,  40 %
  [     1.017385] acpicpu0: T6: I/O, lat   1 us, pow     0 mW,  28 %
  [     1.017385] acpicpu0: T7: I/O, lat   1 us, pow     0 mW,  16 %
  [     1.017385] acpicpu1 at cpu1: ACPI CPU
  [     1.017385] acpicpu2 at cpu2: ACPI CPU

-- 
Kind regards,

Yorick Hardy