Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev



Yes, I thought about providing an ioctl to do this, but it would mean that everything
that talks to those devices would need to be modified to issue the ioctl. Raw mode
means to call the underlying uhidev write which is the raw usb writes instead of
using the report mechanism. My devices did not work using the report mechanism.
Linux provides a /dev/uhidrawN node.

christos

> On Mar 2, 2020, at 11:26 PM, matthew green <mrg%eterna.com.au@localhost> wrote:
> 
> "Christos Zoulas" writes:
>> Module Name:	src
>> Committed By:	christos
>> Date:		Mon Mar  2 18:15:29 UTC 2020
>> 
>> Modified Files:
>> 	src/sys/dev/hid: hid.h
>> 	src/sys/dev/usb: uhid.c
>> 
>> Log Message:
>> Add fido constants, and turn hid "raw" mode for fido devices.
> 
> this is gross.
> 
> please don't put device specific stuff into uhid like this.
> 
> without really understanding, it seems that there should be
> a uhid ioctl to enable this mode, and then your userland code
> sets it, instead of this hack.
> 
> also, please actually explain what this "raw" mode means.  is
> there perhaps a way to avoid this entirely?  what's the real
> underlying need here..?
> 
> 
> .mrg.

Attachment: signature.asc
Description: Message signed with OpenPGP



Home | Main Index | Thread Index | Old Index