Re: CVS commit: src/lib/libc/stdlib

[Valery Ushakov <uwe%stderr.spb.ru@localhost>]

On Sat, Feb 22, 2020 at 14:07:57 +0000, Kamil Rytarowski wrote:

> Module Name:	src
> Committed By:	kamil
> Date:		Sat Feb 22 14:07:57 UTC 2020
> 
> Modified Files:
> 	src/lib/libc/stdlib: _rand48.c
> 
> Log Message:
> Avoid undefined behavior in the rand48(3) implementation
> 
> Instead of implicid promotion to signed int,
> explicitly cast the arguments to unsigned int.

Please, please, please, pay at least some attention to what is going
on around the code you are changing.

If there's already code in this function that does:

   accu = (unsigned long) __rand48_mult[0] * (unsigned long) xseed[0];

then keep it consistent and don't do casts to a different type

   accu += (unsigned int) __rand48_mult[0] * (unsigned int) xseed[2];


-uwe