Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/arm/include/arm32



LGTM too.

christos

On Jan 12, 2020, at 10:09 AM, Jason Thorpe <thorpej%me.com@localhost> wrote:



On Jan 11, 2020, at 10:47 PM, Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost> wrote:

thorpej@ wrote:

PGSHIFT is defined in <machine/param.h> and
PAGE_SHIFT and PAGE_SIZE is in <machine/vmparam.h>,
but there is no common <m68k/vmparam.h>.

Make a common <m68k/vmparam.h> that all of the platforms can #include, and just put these common definitions in it (for now)?

How about the attached diff? (untested, just for review)

This looks good to me.

-- thorpej

Attachment: signature.asc
Description: Message signed with OpenPGP



Home | Main Index | Thread Index | Old Index