While there, it does not build for me:
/usr/src/tests/kernel/h_fexecve.c: In function 'main':
/usr/src/tests/kernel/h_fexecve.c:48:6: error: implicit declaration of
function 'fexecve'; did you mean 'execve'?
[-Werror=implicit-function-declaration]
if (fexecve(fd, args, NULL) == -1)
^~~~~~~
execve
cc1: all warnings being treated as errors
On 15.09.2019 22:37, Kamil Rytarowski wrote:
> I have got no opinion, but merging them is good. Personally I prefer
> src/libc/* path as fexecve(2) is a libc public symbol.
>
> On 15.09.2019 20:06, Christos Zoulas wrote:
>> The tests are a different. Should we keep them both, or try to merge them?
>> I think that merging them is probably better. It is also the case that perhaps
>> we need to get rid of the kernel tests directory and move them to the
>> respective bin and lib directories to avoid confusion?
>>
>> christos
>>
>>> On Sep 15, 2019, at 1:02 PM, Kamil Rytarowski <n54%gmx.com@localhost> wrote:
>>>
>>> Signed PGP part
>>> On 15.09.2019 18:53, Christos Zoulas wrote:
>>>> Module Name: src
>>>> Committed By: christos
>>>> Date: Sun Sep 15 16:53:58 UTC 2019
>>>>
>>>> Modified Files:
>>>> src/tests/kernel: Makefile
>>>> Added Files:
>>>> src/tests/kernel: h_fexecve.c t_fexecve.sh
>>>>
>>>> Log Message:
>>>> Add tests for fexecve(2)
>>>
>>> For the reference, there were already tests in:
>>>
>>> ./lib/libc/c063/t_fexecve
>>>
>>>
>>> <sanitizer.log>
>>
>
>
Attachment:
signature.asc
Description: OpenPGP digital signature