Re: CVS commit: src/usr.bin/elf2aout

[Christos Zoulas <christos%zoulas.com@localhost>]

No we should not be checking new mid numbers. Let a.out rest :-). I will fix it, but I wonder why it built for me. Ah you are building the tool version that has old headers! I will update them!

christos

On May 18, 2019, at 7:45 PM, Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost> wrote:

>> Modified Files:
>>    src/usr.bin/elf2aout: elf2aout.1 elf2aout.c
>> 
>> Log Message:
>> - add flag to produce OMAGIC
>> - factor out complicated inline code into simpler functions
>> - add options parsing
> 
> Thank you for your changes.
> 
> But you also put more functional changes not in the log,
> i.e. you added new MID values:
> - EM_AARCH64    (in #ifdef notyet)
> - EM_ALPHA    (in #ifdef notyet)
> - EM_PARISC    (in #ifdef notyet)
> - EM_OR1K
> - EM_PPC64    (in #ifdef notyet)
> - EM_RISCV
> - EM_SH
> - EM_X86_64    (in #ifdef notyet)
> and it causes build failure:
> ---
> /usr/src/tools/m68k-elf2aout/../../usr.bin/elf2aout/elf2aout.c: In function 'get_mid':
> /usr/src/tools/m68k-elf2aout/../../usr.bin/elf2aout/elf2aout.c:134:7: error: 'EM_OR1K' undeclared (first use in this function)
>  case EM_OR1K:
>       ^
> /usr/src/tools/m68k-elf2aout/../../usr.bin/elf2aout/elf2aout.c:134:7: note: each undeclared identifier is reported only once for each function it appears in
> /usr/src/tools/m68k-elf2aout/../../usr.bin/elf2aout/elf2aout.c:135:10: error: 'MID_OR1K' undeclared (first use in this function)
>   return MID_OR1K;
>          ^
> /usr/src/tools/m68k-elf2aout/../../usr.bin/elf2aout/elf2aout.c:148:7: error: 'EM_RISCV' undeclared (first use in this function)
>  case EM_RISCV:
>       ^
> /usr/src/tools/m68k-elf2aout/../../usr.bin/elf2aout/elf2aout.c:149:10: error: 'MID_RISCV' undeclared (first use in this function)
>   return MID_RISCV;
>          ^
> ---
> 
> If we need to check such new MID values, we have to sync aout_mids.h
> and exec_aout.h in src/tools/arm-elf2aout/sys
> and src/tools/m68k-elf2aout/sys dirs with -current ones.
> But I doubt such newer CPUs actually had a.out binaries..
> 
> Furthermore, you also add a new reference of "PT_TLS":
> ---
> +        if (ph[i].p_type == PT_TLS) {
> +            if (debug)
> +                warnx("Can't handle TLS section");
> +            continue;
> +        }
> ---
> and it also causes an error, at least in src/tools/m68k-elf2aout:
> ---
> /usr/src/tools/m68k-elf2aout/../../usr.bin/elf2aout/elf2aout.c: In function 'main':
> /usr/src/tools/m68k-elf2aout/../../usr.bin/elf2aout/elf2aout.c:318:23: error: 'PT_TLS' undeclared (first use in this function)
>   if (ph[i].p_type == PT_TLS) {
>                       ^
> ---
> If we need to check it, we also have to prepare host tool version.
> 
> Thanks,
> 
> ---
> Izumi Tsutsui