Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/sys/kern



"Christos Zoulas" writes:
> Module Name:	src
> Committed By:	christos
> Date:		Tue May  7 20:10:21 UTC 2019
> 
> Modified Files:
> 	src/sys/kern: sys_select.c
> 
> Log Message:
> Use the max limit (aka maxfiles or the moral equivalent of OPEN_MAX) which
> makes poll(2) align with the Posix documentation (which allows EINVAL if
> nfds > OPEN_MAX). From: Anthony Mallet

this seems to still miss the case kre was talking about:

> I also don't believe there's any restriction on including the same
> fd more than once (with diffent bits set in events probably) - perhaps
> might happen in threaded code when one thread is reading from an fd,
> and a diffenent one is writing to it (probably a net connection or tty).

i think 1000 slop might be reasonable, particular if we
document this as kre also suggested :-)


.mrg.


Home | Main Index | Thread Index | Old Index