Re: CVS commit: src/sys/dev/nvmm

[Paul Goyette <paul%whooppee.com@localhost>]

On Sun, 7 Apr 2019, Maxime Villard wrote:

> Module Name:	src
> Committed By:	maxv
> Date:		Sun Apr  7 14:05:15 UTC 2019
>
> Modified Files:
> 	src/sys/dev/nvmm: nvmm.c
>
> Log Message:
> Don't allow unloading when there are still VMs registered, and don't allow
> auto-unloading at all. Not a big problem actually, because since I changed
> the module class it's not auto-loadable anymore.

There's a better way to prevent auto-loading using a proplib file;  it
isn't necessary to adjust the module's class.

Also, MODULE_CLASS_ANY isn't intended to be used as a module's CLASS.
MODULE_CLASS_ANY is intended for "wildcard" matching of the class in
module_load().  For this you probably ought to use MODULE_CLASS_MISC.

(Kamil, you probably also should change the kcov driver module to use
MODULE_CLASS_MISC)

+--------------------+--------------------------+-----------------------+
| Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
| (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
| Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
+--------------------+--------------------------+-----------------------+