re: CVS commit: src/sys/dev/pci

[matthew green <mrg%eterna.com.au@localhost>]

"Michael Lorenz" writes:
> Module Name:	src
> Committed By:	macallan
> Date:		Wed Mar 20 23:05:19 UTC 2019
> 
> Modified Files:
> 	src/sys/dev/pci: radeonfb.c
> 
> Log Message:
> add code to read disabled ROMs, adapted from xf86-video-radeon
> With this radeonfb does The Right Thing(tm) on my 2xDVI mac radeon with
> decidedly non-standard output wiring.
> ( apparently at least *some* mac radeons have a hidden x86 BIOS with valid
>   connector tables )

this seems to potentially malloc(0).  if the disabled rom is
not found, here:

       if (sc->sc_biossz != 0) printf("found disabled BIOS\n");

foundit:
        sc->sc_bios = malloc(sc->sc_biossz, M_DEVBUF, M_WAITOK);

i think the original code that does an early return needs to
reappear around here, and the added conditional at the end
here can go away.

thanks.


.mrg.